Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/remote/afp.rb

Summary

Maintainability
D
1 day
Test Coverage

Method parse_flags has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_flags(flags)
    flags = flags.to_s(2)
    result = {}
    result['Super Client'] = flags[0,1] == '1' ? true : false
    result['UUIDs'] = flags[5,1] == '1' ? true : false
Severity: Minor
Found in lib/msf/core/exploit/remote/afp.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File afp.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Msf

module Exploit::Remote::AFP
  include Msf::Exploit::Remote::Tcp
Severity: Minor
Found in lib/msf/core/exploit/remote/afp.rb - About 2 hrs to fix

    Method parse_login_response_add_send_login_count has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def parse_login_response_add_send_login_count(response, data)
    dhx_s2civ = 'CJalbert'
    dhx_c2civ = 'LWallace'

    flags, command, request_id, error_code, length, reserved = parse_header(response)
    Severity: Minor
    Found in lib/msf/core/exploit/remote/afp.rb - About 1 hr to fix

      Method login has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def login(user, pass)
    if user == ''
      return no_user_authent_login
    end
      Severity: Minor
      Found in lib/msf/core/exploit/remote/afp.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

              return :connection_error
        Severity: Major
        Found in lib/msf/core/exploit/remote/afp.rb - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def parse_flags(flags)
    flags = flags.to_s(2)
    result = {}
    result['Super Client'] = flags[0,1] == '1' ? true : false
    result['UUIDs'] = flags[5,1] == '1' ? true : false
          Severity: Major
          Found in lib/msf/core/exploit/remote/afp.rb and 1 other location - About 4 hrs to fix
          lib/metasploit/framework/afp/client.rb on lines 293..308

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 154.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def read_array(str, offset, afp_network_address=false)
    size = str.unpack("@#{offset}C").first
    pos = offset + 1

    result = []
          Severity: Minor
          Found in lib/msf/core/exploit/remote/afp.rb and 1 other location - About 55 mins to fix
          lib/metasploit/framework/afp/client.rb on lines 253..263

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status