Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/remote/ftp_server.rb

Summary

Maintainability
C
1 day
Test Coverage

Method on_client_data has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def on_client_data(c)
    data = c.get_once
    return if not data

    cmd,arg = data.strip.split(/\s+/, 2)
Severity: Major
Found in lib/msf/core/exploit/remote/ftp_server.rb - About 2 hrs to fix

    Method on_client_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def on_client_data(c)
    data = c.get_once
    return if not data

    cmd,arg = data.strip.split(/\s+/, 2)
    Severity: Minor
    Found in lib/msf/core/exploit/remote/ftp_server.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return
    Severity: Major
    Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return
          Severity: Major
          Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return
            Severity: Major
            Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return
              Severity: Major
              Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return
                Severity: Major
                Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return
                  Severity: Major
                  Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return
                    Severity: Major
                    Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return
                      Severity: Major
                      Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return
                        Severity: Major
                        Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                              return
                          Severity: Major
                          Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                  return
                            Severity: Major
                            Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                    return
                              Severity: Major
                              Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return self.send("on_client_unknown_command", c, cmd.upcase, arg)
                                Severity: Major
                                Found in lib/msf/core/exploit/remote/ftp_server.rb - About 30 mins to fix

                                  There are no issues that match your filters.

                                  Category
                                  Status