Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/remote/http/gitlab/version.rb

Summary

Maintainability
C
7 hrs
Test Coverage

File version.rb has 468 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Msf::Exploit::Remote::HTTP::Gitlab::Version
  # Used to check if the version is correct: must contain at least one dot
  GITLAB_VERSION_PATTERN = '(\d+\.\d+(?:\.\d+)*)'.freeze
  # CSS-based filename fingerprinting
  GITLAB_CSS_PATTERN = '<link rel="stylesheet"(?: media="[a-z]+")? href="/assets/application-([a-z0-9]+)[.]css"'.freeze
Severity: Minor
Found in lib/msf/core/exploit/remote/http/gitlab/version.rb - About 7 hrs to fix

    Method gitlab_version_css has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def gitlab_version_css(url)
    res = send_request_cgi!(
      'method' => 'GET',
      'uri' => url
    )
    Severity: Minor
    Found in lib/msf/core/exploit/remote/http/gitlab/version.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status