Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/remote/smb/client/psexec.rb

Summary

Maintainability
D
2 days
Test Coverage

File psexec.rb has 355 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'windows_error'
require 'windows_error/win32'
include WindowsError::Win32

module Msf
Severity: Minor
Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 4 hrs to fix

    Method psexec has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def psexec(command, disconnect=true)
    remove_socket(self.sock)
    simple.connect("\\\\#{simple.address}\\IPC$")
    handle = dcerpc_handle_target('367abb81-9844-35f1-ad32-98f038001003', '2.0', 'ncacn_np', ["\\svcctl"], simple.address)
    vprint_status("Binding to #{handle} ...")
    Severity: Major
    Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 3 hrs to fix

      Method native_upload has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def native_upload(smb_share, filename, service_encoder)
    # Upload the shellcode to a file
    print_status("Uploading payload... #{filename}")
    smbshare = smb_share
    fileprefix = ""
      Severity: Minor
      Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method native_upload has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def native_upload(smb_share, filename, service_encoder)
    # Upload the shellcode to a file
    print_status("Uploading payload... #{filename}")
    smbshare = smb_share
    fileprefix = ""
      Severity: Major
      Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 2 hrs to fix

        Method psexec has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def psexec(command, disconnect=true)
    remove_socket(self.sock)
    simple.connect("\\\\#{simple.address}\\IPC$")
    handle = dcerpc_handle_target('367abb81-9844-35f1-ad32-98f038001003', '2.0', 'ncacn_np', ["\\svcctl"], simple.address)
    vprint_status("Binding to #{handle} ...")
        Severity: Minor
        Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute_command_with_output has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def execute_command_with_output(text, bat, cmd, smb_share, r_ip, delay: 0, retries: 0)
    res = execute_command(text, bat, cmd)
       if res
         for i in 0..(retries)
           Rex.sleep(delay)
        Severity: Minor
        Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute_command_with_output has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def execute_command_with_output(text, bat, cmd, smb_share, r_ip, delay: 0, retries: 0)
        Severity: Minor
        Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 35 mins to fix

          Method execute_powershell_payload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def execute_powershell_payload
    ENV['MSF_SERVICENAME'] = datastore['SERVICE_NAME']
    command = cmd_psh_payload(payload.encoded, payload_instance.arch.first)

    if datastore['PSH::persist'] and not datastore['DisablePayloadHandler']
          Severity: Minor
          Found in lib/msf/core/exploit/remote/smb/client/psexec.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                simple.connect("\\\\#{host}\\#{smbshare}")
      file = simple.open(file, 'o')
      contents = file.read
      file.close
      simple.disconnect("\\\\#{host}\\#{smbshare}")
          Severity: Minor
          Found in lib/msf/core/exploit/remote/smb/client/psexec.rb and 1 other location - About 25 mins to fix
          modules/auxiliary/scanner/smb/psexec_loggedin_users.rb on lines 96..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 29.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status