Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/handler/bind_named_pipe.rb

Summary

Maintainability
C
1 day
Test Coverage

Method start_handler has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

      def start_handler
        # Maximum number of seconds to run the handler
        ctimeout = 150

        if (exploit_config and exploit_config['active_timeout'])
Severity: Minor
Found in lib/msf/core/handler/bind_named_pipe.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_handler has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def start_handler
        # Maximum number of seconds to run the handler
        ctimeout = 150

        if (exploit_config and exploit_config['active_timeout'])
Severity: Major
Found in lib/msf/core/handler/bind_named_pipe.rb - About 3 hrs to fix

    File bind_named_pipe.rb has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'thread'

#
# KNOWN ISSUES
#
    Severity: Minor
    Found in lib/msf/core/handler/bind_named_pipe.rb - About 2 hrs to fix

      Method read has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def read(count)
    data = ''
    if count > self.read_buff.length
      # need more data to satisfy request
      self.mutex.synchronize do
      Severity: Minor
      Found in lib/msf/core/handler/bind_named_pipe.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status