rapid7/metasploit-framework

View on GitHub
lib/msf/core/module/platform.rb

Summary

Maintainability
C
7 hrs
Test Coverage

File platform.rb has 376 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'abbrev'

#
# This is the definitions of which Platforms the framework knows about.  The
# relative ranks are used to support ranges, and the Short names are used to
Severity: Minor
Found in lib/msf/core/module/platform.rb - About 5 hrs to fix

    Method find_portion has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.find_portion(mod, str)
        # Check to see if we've built the abbreviated cache
        if (not (
              mod.const_defined?('Abbrev') and
              mod.const_defined?('Names') and
    Severity: Minor
    Found in lib/msf/core/module/platform.rb - About 1 hr to fix

      Method find_portion has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.find_portion(mod, str)
          # Check to see if we've built the abbreviated cache
          if (not (
                mod.const_defined?('Abbrev') and
                mod.const_defined?('Names') and
      Severity: Minor
      Found in lib/msf/core/module/platform.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status