lib/msf/core/modules/metadata/cache.rb
Method refresh_metadata
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
Open
def refresh_metadata(module_sets)
has_changes = false
@mutex.synchronize {
unchanged_module_references = get_unchanged_module_references
module_sets.each do |mt|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method refresh_metadata
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def refresh_metadata(module_sets)
has_changes = false
@mutex.synchronize {
unchanged_module_references = get_unchanged_module_references
module_sets.each do |mt|
Method get_unchanged_module_references
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def get_unchanged_module_references
skip_reference_name_set_by_module_type = Hash.new { |hash, module_type|
hash[module_type] = Set.new
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"