Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/payload/bsd/x86.rb

Summary

Maintainability
A
4 hrs
Test Coverage

Method handle_x86_bsd_opts has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def handle_x86_bsd_opts(pre, app)
    if (datastore['PrependSetresuid'])
      # setresuid(0, 0, 0)
      pre << "\x31\xc0"             + #   xorl    %eax,%eax                  #
             "\x50"                 + #   pushl   %eax                       #
Severity: Major
Found in lib/msf/core/payload/bsd/x86.rb - About 2 hrs to fix

    Method bsd_x86_exec_payload has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def bsd_x86_exec_payload
    cmd_str   = datastore['CMD'] || ''
    # Split the cmd string into arg chunks
    cmd_parts = Shellwords.shellsplit(cmd_str)
    # the non-exe-path parts of the chunks need to be reversed for execve
    Severity: Minor
    Found in lib/msf/core/payload/bsd/x86.rb - About 1 hr to fix

      Method handle_x86_bsd_opts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def handle_x86_bsd_opts(pre, app)
    if (datastore['PrependSetresuid'])
      # setresuid(0, 0, 0)
      pre << "\x31\xc0"             + #   xorl    %eax,%eax                  #
             "\x50"                 + #   pushl   %eax                       #
      Severity: Minor
      Found in lib/msf/core/payload/bsd/x86.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status