Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/payload/stager.rb

Summary

Maintainability
C
1 day
Test Coverage

Method handle_connection has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def handle_connection(conn, opts={})

    # If the stage should be sent over the client connection that is
    # established (which is the default), then go ahead and transmit it.
    if (stage_over_connection?)
Severity: Minor
Found in lib/msf/core/payload/stager.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encode_stage has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def encode_stage(stg)
    return stg unless encode_stage?
    stage_enc_mod = nil

    # Handle StageEncoder if specified by the user
Severity: Minor
Found in lib/msf/core/payload/stager.rb - About 1 hr to fix

    Method encode_stage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def encode_stage(stg)
    return stg unless encode_stage?
    stage_enc_mod = nil

    # Handle StageEncoder if specified by the user
    Severity: Minor
    Found in lib/msf/core/payload/stager.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handle_connection has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def handle_connection(conn, opts={})

    # If the stage should be sent over the client connection that is
    # established (which is the default), then go ahead and transmit it.
    if (stage_over_connection?)
    Severity: Minor
    Found in lib/msf/core/payload/stager.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status