Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/payload/windows/bind_tcp_rc4.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method asm_block_recv_rc4 has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def asm_block_recv_rc4(opts={})
    xorkey = Rex::Text.to_dword(opts[:xorkey]).chomp
    reliable     = opts[:reliable]
    asm = %Q^
      recv:
Severity: Major
Found in lib/msf/core/payload/windows/bind_tcp_rc4.rb - About 3 hrs to fix

    Method asm_block_recv_rc4 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def asm_block_recv_rc4(opts={})
    xorkey = Rex::Text.to_dword(opts[:xorkey]).chomp
    reliable     = opts[:reliable]
    asm = %Q^
      recv:
    Severity: Minor
    Found in lib/msf/core/payload/windows/bind_tcp_rc4.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def generate(_opts = {})
    xorkey, rc4key = rc4_keys(datastore['RC4PASSWORD'])
    conf = {
      port:     datastore['LPORT'],
      xorkey:      xorkey,
    Severity: Major
    Found in lib/msf/core/payload/windows/bind_tcp_rc4.rb and 1 other location - About 1 hr to fix
    lib/msf/core/payload/windows/x64/bind_tcp_rc4_x64.rb on lines 19..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

      def generate_bind_tcp_rc4(opts={})
    combined_asm = %Q^
      cld                    ; Clear the direction flag.
      call start             ; Call start, this pushes the address of 'api_call' onto the stack.
      #{asm_block_api}
    Severity: Major
    Found in lib/msf/core/payload/windows/bind_tcp_rc4.rb and 10 other locations - About 15 mins to fix
    lib/msf/core/payload/windows/bind_tcp.rb on lines 61..71
    lib/msf/core/payload/windows/reverse_tcp.rb on lines 64..74
    lib/msf/core/payload/windows/reverse_tcp_dns.rb on lines 48..58
    lib/msf/core/payload/windows/reverse_tcp_rc4.rb on lines 43..53
    lib/msf/core/payload/windows/reverse_tcp_rc4_dns.rb on lines 43..53
    lib/msf/core/payload/windows/reverse_udp.rb on lines 43..53
    lib/msf/core/payload/windows/x64/bind_tcp_rc4_x64.rb on lines 48..59
    lib/msf/core/payload/windows/x64/bind_tcp_x64.rb on lines 56..67
    lib/msf/core/payload/windows/x64/reverse_tcp_rc4_x64.rb on lines 50..61
    lib/msf/core/payload/windows/x64/reverse_tcp_x64.rb on lines 57..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status