Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/payload/windows/reverse_tcp.rb

Summary

Maintainability
C
1 day
Test Coverage

Method asm_reverse_tcp has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def asm_reverse_tcp(opts={})

    retry_count  = [opts[:retry_count].to_i, 1].max
    encoded_port = "0x%.8x" % [opts[:port].to_i,2].pack("vn").unpack("N").first
    encoded_host = "0x%.8x" % Rex::Socket.addr_aton(opts[:host]||"127.127.127.127").unpack("V").first
Severity: Major
Found in lib/msf/core/payload/windows/reverse_tcp.rb - About 3 hrs to fix

    Method asm_block_recv has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def asm_block_recv(opts={})
    reliable     = opts[:reliable]
    asm = %Q^
      recv:
        ; Receive the size of the incoming second stage...
    Severity: Major
    Found in lib/msf/core/payload/windows/reverse_tcp.rb - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def asm_block_recv(opts={})
    reliable     = opts[:reliable]
    asm = %Q^
      recv:
        ; Receive the size of the incoming second stage...
      Severity: Major
      Found in lib/msf/core/payload/windows/reverse_tcp.rb and 1 other location - About 1 hr to fix
      lib/msf/core/payload/windows/x64/reverse_tcp_x64.rb on lines 192..290

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

        def generate_reverse_tcp(opts={})
    combined_asm = %Q^
      cld                    ; Clear the direction flag.
      call start             ; Call start, this pushes the address of 'api_call' onto the stack.
      #{asm_block_api}
      Severity: Major
      Found in lib/msf/core/payload/windows/reverse_tcp.rb and 10 other locations - About 15 mins to fix
      lib/msf/core/payload/windows/bind_tcp.rb on lines 61..71
      lib/msf/core/payload/windows/bind_tcp_rc4.rb on lines 41..51
      lib/msf/core/payload/windows/reverse_tcp_dns.rb on lines 48..58
      lib/msf/core/payload/windows/reverse_tcp_rc4.rb on lines 43..53
      lib/msf/core/payload/windows/reverse_tcp_rc4_dns.rb on lines 43..53
      lib/msf/core/payload/windows/reverse_udp.rb on lines 43..53
      lib/msf/core/payload/windows/x64/bind_tcp_rc4_x64.rb on lines 48..59
      lib/msf/core/payload/windows/x64/bind_tcp_x64.rb on lines 56..67
      lib/msf/core/payload/windows/x64/reverse_tcp_rc4_x64.rb on lines 50..61
      lib/msf/core/payload/windows/x64/reverse_tcp_x64.rb on lines 57..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status