Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/post/linux/busy_box.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method busy_box_write_file has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def busy_box_write_file(file_path, data, prepend = false)
    if prepend
      dir = busy_box_writable_dir
      return false unless dir
      cmd_exec("cp -f #{file_path} #{dir}tmp")
Severity: Minor
Found in lib/msf/core/post/linux/busy_box.rb - About 1 hr to fix

    Method busy_box_write_file has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def busy_box_write_file(file_path, data, prepend = false)
    if prepend
      dir = busy_box_writable_dir
      return false unless dir
      cmd_exec("cp -f #{file_path} #{dir}tmp")
    Severity: Minor
    Found in lib/msf/core/post/linux/busy_box.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status