Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/post/linux/compile.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method upload_and_compile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def upload_and_compile(path, data, compiler_args='')
    write_file "#{path}.c", strip_comments(data)

    compiler = datastore['COMPILER']
    if datastore['COMPILER'] == 'Auto'
Severity: Minor
Found in lib/msf/core/post/linux/compile.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method live_compile? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def live_compile?
    return false unless %w{ Auto True }.include?(datastore['COMPILE'])

    if datastore['COMPILER'] == 'gcc' && has_gcc?
      vprint_good 'gcc is installed'
Severity: Minor
Found in lib/msf/core/post/linux/compile.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status