Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/rpc/v10/service.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method process has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def process(req)
    msg  = nil

    begin
      if req.method != "POST"
Severity: Minor
Found in lib/msf/core/rpc/v10/service.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def process(req)
    msg  = nil

    begin
      if req.method != "POST"
Severity: Minor
Found in lib/msf/core/rpc/v10/service.rb - About 1 hr to fix

    Method authenticate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def authenticate(token)
    stale = []


    unless (token && token.kind_of?(::String))
    Severity: Minor
    Found in lib/msf/core/rpc/v10/service.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(framework, options={})
    self.framework = framework
    self.handlers = {}
    self.options  = {
      :ssl  => true,
    Severity: Minor
    Found in lib/msf/core/rpc/v10/service.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status