Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/ui/console/command_dispatcher/db/klist.rb

Summary

Maintainability
C
1 day
Test Coverage

Method cmd_klist has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def cmd_klist(*args)
    return unless active?

    entries_affected = 0
    mode = :list
Severity: Minor
Found in lib/msf/ui/console/command_dispatcher/db/klist.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cmd_klist has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def cmd_klist(*args)
    return unless active?

    entries_affected = 0
    mode = :list
Severity: Major
Found in lib/msf/ui/console/command_dispatcher/db/klist.rb - About 3 hrs to fix

    Method ticket_search has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def ticket_search(host_ranges, id_search, workspace: framework.db.workspace)
    ticket_results = []

    # Iterating over each id here since the remote db doesn't support bulk id searches
    if id_search
    Severity: Minor
    Found in lib/msf/ui/console/command_dispatcher/db/klist.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ticket_search has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def ticket_search(host_ranges, id_search, workspace: framework.db.workspace)
    ticket_results = []

    # Iterating over each id here since the remote db doesn't support bulk id searches
    if id_search
    Severity: Minor
    Found in lib/msf/ui/console/command_dispatcher/db/klist.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status