Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/net/dns/rr.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class RR has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class RR
      include Net::DNS::Names

      # Regexp matching an RR string
      RR_REGEXP = Regexp.new("^\\s*(\\S+)\\s*(\\d+)?\\s+(" +
Severity: Minor
Found in lib/net/dns/rr.rb - About 2 hrs to fix

    Method new_from_hash has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def new_from_hash(args)

        # Name field is mandatory
        unless args.has_key? :name
          raise RRArgumentError, "RR argument error: need at least RR name"
    Severity: Minor
    Found in lib/net/dns/rr.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_from_string has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def new_from_string(rrstring)

        unless rrstring =~ RR_REGEXP
          raise RRArgumentError,
          "Format error for RR string (maybe CLASS and TYPE not valid?)"
    Severity: Minor
    Found in lib/net/dns/rr.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status