Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/parser/arguments.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method parse has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

      def parse(args, &_block)
        skip_next = 0

        args.each_with_index do |arg, idx|
          if skip_next > 0
Severity: Minor
Found in lib/rex/parser/arguments.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def parse(args, &_block)
        skip_next = 0

        args.each_with_index do |arg, idx|
          if skip_next > 0
Severity: Minor
Found in lib/rex/parser/arguments.rb - About 1 hr to fix

    Method short_args_from_token has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def short_args_from_token(arg)
        compare_arg = arg.dup[1..-1]
        short_args = []
        found_args = {}
        fmt.keys.each do |keys|
    Severity: Minor
    Found in lib/rex/parser/arguments.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method short_arg_from_long_arg has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def short_arg_from_long_arg(long_arg)
        fmt_option = fmt.find { |key, value| value if key.include?(long_arg) }.first
        # if fmt_option == [long_arg] that means that a short flag option for it does not exist
        return if fmt_option.nil? || fmt_option == [long_arg]
    Severity: Minor
    Found in lib/rex/parser/arguments.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status