Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/parser/fs/ntfs.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method cluster_from_attribute_non_resident has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def cluster_from_attribute_non_resident(attribute, cluster_num = 0, size_max = ((2**31) - 1))
        lowvcn = attribute[16, 8].unpack('Q<')[0]
        highvcn = attribute[24, 8].unpack('Q<')[0]
        offset = attribute[32, 2].unpack('v')[0]
        real_size = attribute[48, 8].unpack('Q<')[0]
Severity: Minor
Found in lib/rex/parser/fs/ntfs.rb - About 1 hr to fix

    Method cluster_from_attribute_non_resident has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def cluster_from_attribute_non_resident(attribute, cluster_num = 0, size_max = ((2**31) - 1))
        lowvcn = attribute[16, 8].unpack('Q<')[0]
        highvcn = attribute[24, 8].unpack('Q<')[0]
        offset = attribute[32, 2].unpack('v')[0]
        real_size = attribute[48, 8].unpack('Q<')[0]
    Severity: Minor
    Found in lib/rex/parser/fs/ntfs.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mft_record_attribute has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def mft_record_attribute(mft_record, lazy=true)
        attribute_list_offset = mft_record[20, 2].unpack('C')[0]
        curs = attribute_list_offset
        attribute_identifier = mft_record[curs, 4].unpack('V')[0]
        res = {}
    Severity: Minor
    Found in lib/rex/parser/fs/ntfs.rb - About 1 hr to fix

      Method mft_record_attribute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def mft_record_attribute(mft_record, lazy=true)
        attribute_list_offset = mft_record[20, 2].unpack('C')[0]
        curs = attribute_list_offset
        attribute_identifier = mft_record[curs, 4].unpack('V')[0]
        res = {}
      Severity: Minor
      Found in lib/rex/parser/fs/ntfs.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_index_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse_index_list(index_record, index_allocation_attribute)
        offset_index_entry_list = index_record[0, 4].unpack('V')[0]
        index_size =  index_record[offset_index_entry_list + 8, 2].unpack('v')[0]
        index_size_in_bytes = index_size * @bytes_per_cluster
        index_entry = index_record[offset_index_entry_list, index_size]
      Severity: Minor
      Found in lib/rex/parser/fs/ntfs.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if index_entry[12, 4].unpack('V')[0] & 1 == 1
          # should be 8 bytes length
          vcn =  index_entry[-8, 4].unpack('V')[0]
          vcn_in_bytes = vcn * @bytes_per_cluster
          res_son = parse_index_list(index_allocation_attribute[vcn_in_bytes + 24, index_size_in_bytes], index_allocation_attribute)
      Severity: Minor
      Found in lib/rex/parser/fs/ntfs.rb and 1 other location - About 45 mins to fix
      lib/rex/parser/fs/ntfs.rb on lines 112..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                if index_entry[12, 4].unpack('V')[0] & 1 == 1
            # should be 8 bytes length
            vcn =  index_entry[-8, 4].unpack('V')[0]
            vcn_in_bytes = vcn * @bytes_per_cluster
            res_son = parse_index_list(index_allocation_attribute[vcn_in_bytes + 24, index_size_in_bytes], index_allocation_attribute)
      Severity: Minor
      Found in lib/rex/parser/fs/ntfs.rb and 1 other location - About 45 mins to fix
      lib/rex/parser/fs/ntfs.rb on lines 125..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status