Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/parser/group_policy_preferences.rb

Summary

Maintainability
D
2 days
Test Coverage

Method parse has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse(data)
    if data.nil?
      return []
    end
Severity: Minor
Found in lib/rex/parser/group_policy_preferences.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_tables has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_tables(results, filetype, domain=nil, dc=nil)
    tables = []
    results.each do |result|
      table = Rex::Text::Table.new(
        'Header'     => 'Group Policy Credential Info',
Severity: Minor
Found in lib/rex/parser/group_policy_preferences.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.parse(data)
    if data.nil?
      return []
    end
Severity: Minor
Found in lib/rex/parser/group_policy_preferences.rb - About 2 hrs to fix

    Method decrypt has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.decrypt(encrypted_data)
    password = ""
    return password unless encrypted_data

    password = ""
    Severity: Minor
    Found in lib/rex/parser/group_policy_preferences.rb - About 1 hr to fix

      Method create_tables has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.create_tables(results, filetype, domain=nil, dc=nil)
    tables = []
    results.each do |result|
      table = Rex::Text::Table.new(
        'Header'     => 'Group Policy Credential Info',
      Severity: Minor
      Found in lib/rex/parser/group_policy_preferences.rb - About 1 hr to fix

        Method decrypt has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.decrypt(encrypted_data)
    password = ""
    return password unless encrypted_data

    password = ""
        Severity: Minor
        Found in lib/rex/parser/group_policy_preferences.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status