Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/parser/netsparker_xml.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method text has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def text(str)
    case @state
    when :in_url
      @vuln['url'] ||= ""
      @vuln['url']  += str
Severity: Minor
Found in lib/rex/parser/netsparker_xml.rb - About 1 hr to fix

    Method text has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def text(str)
    case @state
    when :in_url
      @vuln['url'] ||= ""
      @vuln['url']  += str
    Severity: Minor
    Found in lib/rex/parser/netsparker_xml.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tag_end has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def tag_end(name)
    case name
    when "vulnerability"
      @vuln.keys.each do |k|
        @vuln[k] = @vuln[k].strip if @vuln[k].kind_of?(::String)
    Severity: Minor
    Found in lib/rex/parser/netsparker_xml.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status