Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/payloads/meterpreter/uri_checksum.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method generate_uri_checksum has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def generate_uri_checksum(sum, len=5, prefix="")
          # Lengths shorter than 4 bytes are unable to match all possible checksums
          # Lengths of exactly 4 are relatively slow to find for high checksum values
          # Lengths of 5 or more bytes find a matching checksum fairly quickly (~80ms)
          if len < URI_CHECKSUM_MIN_LEN
Severity: Minor
Found in lib/rex/payloads/meterpreter/uri_checksum.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status