Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb

Summary

Maintainability
D
3 days
Test Coverage

File core.rb has 428 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'set'
require 'rex/post/hwbridge'

module Rex
module Post
Severity: Minor
Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 6 hrs to fix

    Class Core has 37 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Console::CommandDispatcher::Core

  include Console::CommandDispatcher

  #
    Severity: Minor
    Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 4 hrs to fix

      Method add_extension_client has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

        def add_extension_client(mod)
    loaded = false
    klass = nil
    self.class.client_extension_search_paths.each do |path|
      path = ::File.join(path, "#{mod}.rb")
      Severity: Minor
      Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cmd_status has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def cmd_status(*args)
    if args.length > 0
      cmd_status_help
      return true
    end
      Severity: Minor
      Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cmd_run_tabs has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def cmd_run_tabs(str, words)
    tabs = []
    if !words[1] || !words[1].match(/^\//)
      begin
        if msf_loaded?
      Severity: Minor
      Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_extension_client has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def add_extension_client(mod)
    loaded = false
    klass = nil
    self.class.client_extension_search_paths.each do |path|
      path = ::File.join(path, "#{mod}.rb")
      Severity: Minor
      Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 1 hr to fix

        Method cmd_load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def cmd_load(*args)
    if args.length.zero?
      args.unshift("-h")
    end
        Severity: Minor
        Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 1 hr to fix

          Method cmd_run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def cmd_run(*args)
    if args.length.zero?
      cmd_run_help
      return true
    end
          Severity: Minor
          Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 1 hr to fix

            Method cmd_info has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def cmd_info(*args)
    return unless msf_loaded?

    if args.length != 1 || args.include?('-h')
      cmd_info_help
            Severity: Minor
            Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_load has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def cmd_load(*args)
    if args.length.zero?
      args.unshift("-h")
    end
            Severity: Minor
            Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def cmd_run(*args)
    if args.length.zero?
      cmd_run_help
      return true
    end
            Severity: Minor
            Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cmd_load_custom_methods has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def cmd_load_custom_methods(*args)
    if args.length > 0
      cmd_load_custom_methods_help
      return true
    end
            Severity: Minor
            Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                c = {
      "?"          => "Help menu",
      "background" => "Backgrounds the current session",
      "exit"       => "Terminate the hardware bridge session",
      "help"       => "Help menu",
            Severity: Minor
            Found in lib/rex/post/hwbridge/ui/console/command_dispatcher/core.rb and 1 other location - About 30 mins to fix
            lib/msf/ui/console/command_dispatcher/modules.rb on lines 41..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status