Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/post/meterpreter/extensions/stdapi/webcam/webcam.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method init_video_chat has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def init_video_chat(remote_browser_path, server, channel, offerer_id)
    interface = load_interface('offerer.html')
    api       = load_api_code

    interface = interface.gsub(/\=SERVER\=/, server)
Severity: Minor
Found in lib/rex/post/meterpreter/extensions/stdapi/webcam/webcam.rb - About 1 hr to fix

    Method webrtc_browser_path has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def webrtc_browser_path
    found_browser_path = ''

    case client.platform
    when /win/
    Severity: Minor
    Found in lib/rex/post/meterpreter/extensions/stdapi/webcam/webcam.rb - About 1 hr to fix

      Method webrtc_browser_path has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def webrtc_browser_path
    found_browser_path = ''

    case client.platform
    when /win/
      Severity: Minor
      Found in lib/rex/post/meterpreter/extensions/stdapi/webcam/webcam.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init_video_chat has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def init_video_chat(remote_browser_path, server, channel, offerer_id)
    interface = load_interface('offerer.html')
    api       = load_api_code

    interface = interface.gsub(/\=SERVER\=/, server)
      Severity: Minor
      Found in lib/rex/post/meterpreter/extensions/stdapi/webcam/webcam.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status