Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method cmd_list_tokens has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def cmd_list_tokens(*args)
    token_order = -1

    @@list_tokens_opts.parse(args) { |opt, idx, val|
      case opt
Severity: Minor
Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def cmd_add_user(*args)
    # Default to localhost
    host = "127.0.0.1"

    @@add_user_opts.parse(args) { |opt, idx, val|
    Severity: Major
    Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb and 2 other locations - About 1 hr to fix
    lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb on lines 147..174
    lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb on lines 177..204

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def cmd_add_localgroup_user(*args)
    # Default to localhost
    host = "127.0.0.1"

    @@add_localgroup_user_opts.parse(args) { |opt, idx, val|
    Severity: Major
    Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb and 2 other locations - About 1 hr to fix
    lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb on lines 117..144
    lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb on lines 177..204

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      def cmd_add_group_user(*args)
    # Default to localhost
    host = "127.0.0.1"

    @@add_group_user_opts.parse(args) { |opt, idx, val|
    Severity: Major
    Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb and 2 other locations - About 1 hr to fix
    lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb on lines 117..144
    lib/rex/post/meterpreter/ui/console/command_dispatcher/incognito.rb on lines 147..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status