Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/addp.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method decode_reply has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.decode_reply(data)
      res = {}
      r_magic = data[0,4]
      r_ptype = data[4,2].unpack("n").first
      r_plen  = data[6,2].unpack("n").first
Severity: Major
Found in lib/rex/proto/addp.rb - About 3 hrs to fix

    Method decode_reply has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.decode_reply(data)
      res = {}
      r_magic = data[0,4]
      r_ptype = data[4,2].unpack("n").first
      r_plen  = data[6,2].unpack("n").first
    Severity: Minor
    Found in lib/rex/proto/addp.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method request_static_ip has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.request_static_ip(magic, dmac, ip, mask, gw, pwd="dbps")
    Severity: Minor
    Found in lib/rex/proto/addp.rb - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status