Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/amqp/version_0_9_1/client.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method recv_frame has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def recv_frame
    remaining = @timeout
    header_raw, elapsed_time = Rex::Stopwatch.elapsed_time do
      num_bytes = Version091::Frames::AmqpVersion091FrameHeader.new.num_bytes
      @conn.get_once(num_bytes, remaining)
Severity: Minor
Found in lib/rex/proto/amqp/version_0_9_1/client.rb - About 1 hr to fix

    Method is_method_frame? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def is_method_frame?(resp, klass=nil)
    return false unless resp.is_a?(Version091::Frames::AmqpVersion091MethodFrame)

    if klass
      return false unless resp.class_id == klass::CLASS_ID
    Severity: Minor
    Found in lib/rex/proto/amqp/version_0_9_1/client.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method recv_frame has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def recv_frame
    remaining = @timeout
    header_raw, elapsed_time = Rex::Stopwatch.elapsed_time do
      num_bytes = Version091::Frames::AmqpVersion091FrameHeader.new.num_bytes
      @conn.get_once(num_bytes, remaining)
    Severity: Minor
    Found in lib/rex/proto/amqp/version_0_9_1/client.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status