Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/http/packet.rb

Summary

Maintainability
D
1 day
Test Coverage

Method output_packet has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def output_packet(ignore_chunk = false, headers_only: false)
    content = self.body.to_s.dup

    # Update the content length field in the header with the body length.
    if (content)
Severity: Minor
Found in lib/rex/proto/http/packet.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_body has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_body
    # Just return if the buffer is empty
    if (self.bufq.length == 0)
      return
    end
Severity: Minor
Found in lib/rex/proto/http/packet.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_header has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_header(opts)

    head,data = self.bufq.split(/\r?\n\r?\n/, 2)

    return if data.nil?
Severity: Minor
Found in lib/rex/proto/http/packet.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_body has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_body
    # Just return if the buffer is empty
    if (self.bufq.length == 0)
      return
    end
Severity: Minor
Found in lib/rex/proto/http/packet.rb - About 1 hr to fix

    Method output_packet has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def output_packet(ignore_chunk = false, headers_only: false)
    content = self.body.to_s.dup

    # Update the content length field in the header with the body length.
    if (content)
    Severity: Minor
    Found in lib/rex/proto/http/packet.rb - About 1 hr to fix

      Method parse_header has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def parse_header(opts)

    head,data = self.bufq.split(/\r?\n\r?\n/, 2)

    return if data.nil?
      Severity: Minor
      Found in lib/rex/proto/http/packet.rb - About 1 hr to fix

        Method parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse(buf, opts={})

    # Append the incoming buffer to the buffer queue.
    self.bufq += buf.to_s
        Severity: Minor
        Found in lib/rex/proto/http/packet.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return
        Severity: Major
        Found in lib/rex/proto/http/packet.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return
          Severity: Major
          Found in lib/rex/proto/http/packet.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return
            Severity: Major
            Found in lib/rex/proto/http/packet.rb - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status