Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/kerberos/crypto/rc4_hmac.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method gss_wrap has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def gss_wrap(plaintext, key, sequence_number, is_initiator, opts={})
            dce_style = opts.fetch(:dce_style) { false }
            pad_style = opts.fetch(:rc4_pad_style) { :single_byte }
            # Always 32-bit sequence number
            sequence_number &= 0xFFFFFFFF
Severity: Major
Found in lib/rex/proto/kerberos/crypto/rc4_hmac.rb - About 2 hrs to fix

    Method gss_unwrap has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

              def gss_unwrap(ciphertext, key, expected_sequence_number, is_initiator, opts={})
            # Always 32-bit sequence number
            expected_sequence_number &= 0xFFFFFFFF unless expected_sequence_number.nil?

            mech_id, ciphertext = unwrap_pseudo_asn1(ciphertext)
    Severity: Minor
    Found in lib/rex/proto/kerberos/crypto/rc4_hmac.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method gss_unwrap has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def gss_unwrap(ciphertext, key, expected_sequence_number, is_initiator, opts={})
            # Always 32-bit sequence number
            expected_sequence_number &= 0xFFFFFFFF unless expected_sequence_number.nil?

            mech_id, ciphertext = unwrap_pseudo_asn1(ciphertext)
    Severity: Minor
    Found in lib/rex/proto/kerberos/crypto/rc4_hmac.rb - About 1 hr to fix

      Method gss_wrap has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                def gss_wrap(plaintext, key, sequence_number, is_initiator, opts={})
      Severity: Minor
      Found in lib/rex/proto/kerberos/crypto/rc4_hmac.rb - About 35 mins to fix

        Method gss_unwrap has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                  def gss_unwrap(ciphertext, key, expected_sequence_number, is_initiator, opts={})
        Severity: Minor
        Found in lib/rex/proto/kerberos/crypto/rc4_hmac.rb - About 35 mins to fix

          Method gss_wrap has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                    def gss_wrap(plaintext, key, sequence_number, is_initiator, opts={})
            dce_style = opts.fetch(:dce_style) { false }
            pad_style = opts.fetch(:rc4_pad_style) { :single_byte }
            # Always 32-bit sequence number
            sequence_number &= 0xFFFFFFFF
          Severity: Minor
          Found in lib/rex/proto/kerberos/crypto/rc4_hmac.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status