Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/kerberos/pac/krb5_pac.rb

Summary

Maintainability
C
1 day
Test Coverage

File krb5_pac.rb has 451 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bindata'
require 'ruby_smb/dcerpc'
require 'rex/proto/ms_dtyp'

# full MIDL spec for PAC
Severity: Minor
Found in lib/rex/proto/kerberos/pac/krb5_pac.rb - About 6 hrs to fix

    Method calculate_checksums! has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def calculate_checksums!(service_key: nil, krbtgt_key: nil)
      server_checksum = nil
      priv_server_checksum = nil
      full_pac_checksum = nil
      pac_info_buffers.each do |info_buffer|
    Severity: Minor
    Found in lib/rex/proto/kerberos/pac/krb5_pac.rb - About 1 hr to fix

      Method calculate_checksums! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def calculate_checksums!(service_key: nil, krbtgt_key: nil)
      server_checksum = nil
      priv_server_checksum = nil
      full_pac_checksum = nil
      pac_info_buffers.each do |info_buffer|
      Severity: Minor
      Found in lib/rex/proto/kerberos/pac/krb5_pac.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status