Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/mssql/client.rb

Summary

Maintainability
F
3 days
Test Coverage

Method mssql_login has 246 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def mssql_login(user='sa', pass='', db='', domain_name='')
          prelogin_data = mssql_prelogin
          if auth == Msf::Exploit::Remote::AuthOption::KERBEROS
            idx = 0
            pkt = ''
Severity: Major
Found in lib/rex/proto/mssql/client.rb - About 1 day to fix

    File client.rb has 477 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'metasploit/framework/tcp/client'
require 'metasploit/framework/mssql/tdssslproxy'
require 'rex/proto/mssql/client_mixin'
require 'rex/text'
require 'msf/core/exploit'
    Severity: Minor
    Found in lib/rex/proto/mssql/client.rb - About 7 hrs to fix

      Method mssql_login has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

              def mssql_login(user='sa', pass='', db='', domain_name='')
          prelogin_data = mssql_prelogin
          if auth == Msf::Exploit::Remote::AuthOption::KERBEROS
            idx = 0
            pkt = ''
      Severity: Minor
      Found in lib/rex/proto/mssql/client.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mssql_prelogin has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def mssql_prelogin(enc_error=false)
          disconnect if self.sock
          connect

          pkt = mssql_prelogin_packet
      Severity: Minor
      Found in lib/rex/proto/mssql/client.rb - About 1 hr to fix

        Method mssql_upload_exec has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def mssql_upload_exec(exe, debug=false)
          hex = exe.unpack("H*")[0]

          var_bypass  = Rex::Text.rand_text_alpha(8)
          var_payload = Rex::Text.rand_text_alpha(8)
        Severity: Minor
        Found in lib/rex/proto/mssql/client.rb - About 1 hr to fix

          Method mssql_prelogin has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                  def mssql_prelogin(enc_error=false)
          disconnect if self.sock
          connect

          pkt = mssql_prelogin_packet
          Severity: Minor
          Found in lib/rex/proto/mssql/client.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def initialize(framework_module, framework, rhost, rport = 1433, proxies = nil)
          Severity: Minor
          Found in lib/rex/proto/mssql/client.rb - About 35 mins to fix

            Method query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                    def query(sqla, doprint=false, opts={})
          info = { :sql => sqla }
          opts[:timeout] ||= 15
          pkts = []
          idx  = 0
            Severity: Minor
            Found in lib/rex/proto/mssql/client.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method map_compile_arch_to_architecture has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    def map_compile_arch_to_architecture(server_info)
          return '' if server_info.blank?

          arch_data = server_info.downcase.encode(::Encoding::BINARY)
            Severity: Minor
            Found in lib/rex/proto/mssql/client.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    def powershell_upload_exec(exe, debug=false)
          # hex converter
          hex = exe.unpack("H*")[0]
          # create random alpha 8 character names
          #var_bypass  = rand_text_alpha(8)
            Severity: Major
            Found in lib/rex/proto/mssql/client.rb and 1 other location - About 2 hrs to fix
            lib/msf/core/exploit/remote/mssql_sqli.rb on lines 105..130

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status