Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/ntlm/crypt.rb

Summary

Maintainability
D
2 days
Test Coverage

Method is_hash_from_empty_pwd? has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def self.is_hash_from_empty_pwd?(arg)
    hash_type = arg[:type]
    raise ArgumentError,"arg[:type] is mandatory" if not hash_type
    raise ArgumentError,"arg[:type] must be lm or ntlm" if not hash_type  =~ /^((lm)|(ntlm))$/
Severity: Minor
Found in lib/rex/proto/ntlm/crypt.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File crypt.rb has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Rex
module Proto
module NTLM
class Crypt
Severity: Minor
Found in lib/rex/proto/ntlm/crypt.rb - About 3 hrs to fix

    Method is_hash_from_empty_pwd? has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.is_hash_from_empty_pwd?(arg)
    hash_type = arg[:type]
    raise ArgumentError,"arg[:type] is mandatory" if not hash_type
    raise ArgumentError,"arg[:type] must be lm or ntlm" if not hash_type  =~ /^((lm)|(ntlm))$/
    Severity: Major
    Found in lib/rex/proto/ntlm/crypt.rb - About 2 hrs to fix

      Class Crypt has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class Crypt

CONST = Rex::Proto::NTLM::Constants
BASE = Rex::Proto::NTLM::Base
      Severity: Minor
      Found in lib/rex/proto/ntlm/crypt.rb - About 2 hrs to fix

        Method ntlmv2_response has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.ntlmv2_response(arg, opt = {})
    raise RuntimeError, "No OpenSSL support" if not @@loaded_openssl

    key, chal = arg[:ntlmv2_hash], arg[:challenge]
    if not (key and chal)
        Severity: Minor
        Found in lib/rex/proto/ntlm/crypt.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method ntlmv2_response has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.ntlmv2_response(arg, opt = {})
    raise RuntimeError, "No OpenSSL support" if not @@loaded_openssl

    key, chal = arg[:ntlmv2_hash], arg[:challenge]
    if not (key and chal)
        Severity: Minor
        Found in lib/rex/proto/ntlm/crypt.rb - About 1 hr to fix

          Method lmv2_user_session_key has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.lmv2_user_session_key(user, pass, domain, srv_chall, cli_chall, opt = {})
          Severity: Minor
          Found in lib/rex/proto/ntlm/crypt.rb - About 45 mins to fix

            Method make_weak_sessionkey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.make_weak_sessionkey(session_key,key_size,lanman_key = false)
    case key_size
    when 40
      if lanman_key
        return session_key[0,5] + "\xe5\x38\xb0"
            Severity: Minor
            Found in lib/rex/proto/ntlm/crypt.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return session_key[0,16]
            Severity: Major
            Found in lib/rex/proto/ntlm/crypt.rb - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    when 'lm'
        raise ArgumentError,"Client challenge length must be exactly 8 bytes " if cli_chall.length != 8
        arglm = {    :ntlmv2_hash =>  self.ntlmv2_hash(user,'', domain),
            :challenge => srv_chall }
        optlm = {    :client_challenge => cli_chall}
              Severity: Minor
              Found in lib/rex/proto/ntlm/crypt.rb and 1 other location - About 30 mins to fix
              lib/rex/proto/ntlm/crypt.rb on lines 281..286

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    when 'ntlm'
        raise ArgumentError,"Client challenge length must be bigger then 8 bytes " if cli_chall.length <= 8
        argntlm = {     :ntlmv2_hash =>  self.ntlmv2_hash(user, '', domain),
            :challenge => srv_chall }
        optntlm = {     :nt_client_challenge => cli_chall}
              Severity: Minor
              Found in lib/rex/proto/ntlm/crypt.rb and 1 other location - About 30 mins to fix
              lib/rex/proto/ntlm/crypt.rb on lines 275..280

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status