Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/smb/simple_client/open_file.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method read_rex_smb has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def read_rex_smb(length, offset)
        if length.nil?
          data = ''
          fptr = offset
          ok = client.read(file_id, fptr, chunk_size)
Severity: Minor
Found in lib/rex/proto/smb/simple_client/open_file.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read_ruby_smb has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def read_ruby_smb(length, offset, depth = 0)
        file_size = client.open_files[client.last_file_id].size
        file_size_remaining = file_size - offset
        if length.nil?
          max_size = file_size_remaining
Severity: Minor
Found in lib/rex/proto/smb/simple_client/open_file.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read_rex_smb has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def read_rex_smb(length, offset)
        if length.nil?
          data = ''
          fptr = offset
          ok = client.read(file_id, fptr, chunk_size)
Severity: Minor
Found in lib/rex/proto/smb/simple_client/open_file.rb - About 1 hr to fix

    Method read_ruby_smb has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def read_ruby_smb(length, offset, depth = 0)
        file_size = client.open_files[client.last_file_id].size
        file_size_remaining = file_size - offset
        if length.nil?
          max_size = file_size_remaining
    Severity: Minor
    Found in lib/rex/proto/smb/simple_client/open_file.rb - About 1 hr to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(client, name, tree_id, file_id, versions)
      Severity: Minor
      Found in lib/rex/proto/smb/simple_client/open_file.rb - About 35 mins to fix

        Method write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def write(data, offset = 0)
        # Track our offset into the remote file
        fptr = offset

        # Duplicate the data so we can use slice!
        Severity: Minor
        Found in lib/rex/proto/smb/simple_client/open_file.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status