Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/proto/tftp/server.rb

Summary

Maintainability
D
2 days
Test Coverage

Method monitor_socket has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  def monitor_socket
    while true
      rds = [@sock]
      wds = []
      self.transfers.each do |tr|
Severity: Minor
Found in lib/rex/proto/tftp/server.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dispatch_request has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  def dispatch_request(from, buf)

    op = buf.unpack('n')[0]
    buf.slice!(0,2)
Severity: Minor
Found in lib/rex/proto/tftp/server.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File server.rb has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rex/socket'

module Rex
module Proto
module TFTP
Severity: Minor
Found in lib/rex/proto/tftp/server.rb - About 3 hrs to fix

    Method dispatch_request has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def dispatch_request(from, buf)

    op = buf.unpack('n')[0]
    buf.slice!(0,2)
    Severity: Major
    Found in lib/rex/proto/tftp/server.rb - About 3 hrs to fix

      Method process_options has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

        def process_options(from, buf, tr)
    found = 0
    to_ack = []
    while buf.length >= 4
      opt = TFTP::get_string(buf)
      Severity: Minor
      Found in lib/rex/proto/tftp/server.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method monitor_socket has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def monitor_socket
    while true
      rds = [@sock]
      wds = []
      self.transfers.each do |tr|
      Severity: Minor
      Found in lib/rex/proto/tftp/server.rb - About 1 hr to fix

        Method process_options has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def process_options(from, buf, tr)
    found = 0
    to_ack = []
    while buf.length >= 4
      opt = TFTP::get_string(buf)
        Severity: Minor
        Found in lib/rex/proto/tftp/server.rb - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                        tr[:file][:started] = true if (tr[:file][:once])
          Severity: Major
          Found in lib/rex/proto/tftp/server.rb - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (r != nil and r[0] == self.sock)
        buf,host,port = self.sock.recvfrom(65535)
        # Lame compatabilitiy :-/
        from = [host, port]
        dispatch_request(from, buf)
            Severity: Minor
            Found in lib/rex/proto/tftp/server.rb and 1 other location - About 25 mins to fix
            lib/rex/proto/dhcp/server.rb on lines 174..179

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status