Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/services/local_relay.rb

Summary

Maintainability
C
7 hrs
Test Coverage

File local_relay.rb has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'thread'
require 'rex/socket'
module Rex
module Services
Severity: Minor
Found in lib/rex/services/local_relay.rb - About 3 hrs to fix

    Method monitor_relays has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def monitor_relays
    begin
      # Helps with latency
      Thread.current.priority = 2
    Severity: Minor
    Found in lib/rex/services/local_relay.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method monitor_relays has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def monitor_relays
    begin
      # Helps with latency
      Thread.current.priority = 2
    Severity: Minor
    Found in lib/rex/services/local_relay.rb - About 1 hr to fix

      Method close_relay_conn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def close_relay_conn(fd)
    relay = fd.relay
    ofd   = fd.other_stream

    self.rfds.delete(fd)
      Severity: Minor
      Found in lib/rex/services/local_relay.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status