Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/ui/interactive.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method interact has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def interact(user_input, user_output)

    # Detach from any existing console
    if self.interacting
      detach()
Severity: Minor
Found in lib/rex/ui/interactive.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method interact has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def interact(user_input, user_output)

    # Detach from any existing console
    if self.interacting
      detach()
Severity: Minor
Found in lib/rex/ui/interactive.rb - About 1 hr to fix

    Method interact_stream has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def interact_stream(stream)
    while self.interacting && _remote_fd(stream)

      # Select input and rstream
      sd = Rex::ThreadSafe.select([ _local_fd, _remote_fd(stream) ], nil, nil, 0.25)
    Severity: Minor
    Found in lib/rex/ui/interactive.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status