Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/http/gitstack_rest.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'GitStack Unauthenticated REST API Requests',
Severity: Major
Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 2 hrs to fix

    Method add_user has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def add_user
    user = datastore['USERNAME']
    pass = datastore['PASSWORD']

    begin
    Severity: Minor
    Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 1 hr to fix

      Method add_user has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def add_user
    user = datastore['USERNAME']
    pass = datastore['PASSWORD']

    begin
      Severity: Minor
      Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method clean_app has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def clean_app
    user = datastore['USERNAME']
    unless user
      print_error('USERNAME required')
      return
      Severity: Minor
      Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method clean_app has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def clean_app
    user = datastore['USERNAME']
    unless user
      print_error('USERNAME required')
      return
      Severity: Minor
      Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    if ['LIST'].include?(action.name)
      print_status('Retrieving Users')
      get_users
    elsif ['LIST_REPOS'].include?(action.name)
        Severity: Minor
        Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_repos has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_repos
    path = action.opts['RepoPath']
    begin
      res = send_request_cgi({
        'uri' => path,
        Severity: Minor
        Found in modules/auxiliary/admin/http/gitstack_rest.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            begin
      res = send_request_cgi({
        'uri' => path,
        'method' => action.opts['Remove']
      })
        Severity: Minor
        Found in modules/auxiliary/admin/http/gitstack_rest.rb and 2 other locations - About 25 mins to fix
        modules/auxiliary/admin/http/gitstack_rest.rb on lines 100..108
        modules/auxiliary/admin/http/gitstack_rest.rb on lines 159..167

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                begin
          res = send_request_cgi({
            'uri' => path,
            'method' => action.opts['Remove']
          })
        Severity: Minor
        Found in modules/auxiliary/admin/http/gitstack_rest.rb and 2 other locations - About 25 mins to fix
        modules/auxiliary/admin/http/gitstack_rest.rb on lines 100..108
        modules/auxiliary/admin/http/gitstack_rest.rb on lines 179..187

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            begin
      res = send_request_cgi({
        'uri' => path,
        'method' => action.opts['List']
      })
        Severity: Minor
        Found in modules/auxiliary/admin/http/gitstack_rest.rb and 2 other locations - About 25 mins to fix
        modules/auxiliary/admin/http/gitstack_rest.rb on lines 159..167
        modules/auxiliary/admin/http/gitstack_rest.rb on lines 179..187

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status