Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/http/manageengine_pmp_privesc.rb

Summary

Maintainability
D
1 day
Test Coverage

Method login has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def login(username, password)
    # 1st step: we obtain a JSESSIONID cookie...
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'PassTrixMain.cc')
Severity: Minor
Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method login has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def login(username, password)
    # 1st step: we obtain a JSESSIONID cookie...
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'PassTrixMain.cc')
Severity: Major
Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 2 hrs to fix

    File manageengine_pmp_privesc.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::HttpClient
  include Msf::Auxiliary::Report

  def initialize(info = {})
    Severity: Minor
    Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 2 hrs to fix

      Method inject_sql has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def inject_sql(old_style)
    # On versions older than 7000 the injection is slightly different (we call it "old style").
    # For "new style" versions we can escalate to super admin by doing
    # "update aaaauthorizedrole set role_id=1 where account_id=#{user_id};insert into ptrx_superadmin values (#{user_id},true);"
    # However for code simplicity let's just create a brand new user which works for both "old style" and "new style" versions.
      Severity: Minor
      Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 1 hr to fix

        Method loot_passwords has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def loot_passwords(cookie_admin)
    # 1st we turn on password exports
    send_request_cgi({
      'method' => 'POST',
      'uri' => normalize_uri(target_uri.path, 'ConfigureOffline.ve'),
        Severity: Minor
        Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 1 hr to fix

          Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'ManageEngine Password Manager SQLAdvancedALSearchResult.cc Pro SQL Injection',
          Severity: Minor
          Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if res && res.code == 200 && res.body &&
       res.body.to_s =~ /ManageEngine Password Manager Pro/ &&
       (
         res.body.to_s =~ /login\.css\?([0-9]+)/ ||                            # PMP v6
         res.body.to_s =~ /login\.css\?version=([0-9]+)/ ||                    # PMP v6
            Severity: Major
            Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb - About 1 hr to fix

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

                  register_options(
      [
        Opt::RPORT(7272),
        OptBool.new('SSL', [true, 'Use SSL', true]),
        OptString.new('USERNAME', [true, 'The username to login as', 'guest']),
              Severity: Major
              Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb and 6 other locations - About 30 mins to fix
              modules/auxiliary/gather/mcafee_epo_xxe.rb on lines 46..53
              modules/exploits/linux/http/f5_icall_cmd.rb on lines 52..59
              modules/exploits/linux/http/f5_icontrol_exec.rb on lines 39..46
              modules/exploits/linux/http/lifesize_uvc_ping_rce.rb on lines 47..54
              modules/exploits/multi/http/cisco_dcnm_upload_2019.rb on lines 63..70
              modules/exploits/windows/ibm/ibm_was_dmgr_java_deserialization_rce.rb on lines 51..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status