Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/http/telpho10_credential_dump.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    res = send_request_cgi({
      'uri' => '/telpho/system/backup.php',
      'method' => 'GET'
    })
Severity: Minor
Found in modules/auxiliary/admin/http/telpho10_credential_dump.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    res = send_request_cgi({
      'uri' => '/telpho/system/backup.php',
      'method' => 'GET'
    })
Severity: Minor
Found in modules/auxiliary/admin/http/telpho10_credential_dump.rb - About 2 hrs to fix

    Method dump_creds has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def dump_creds(mysql_file)
    file = File.new(mysql_file, 'r')
    while (line = file.gets)
      if line.include? 'adminusername'
        config = [line]
    Severity: Minor
    Found in modules/auxiliary/admin/http/telpho10_credential_dump.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return nil
      Severity: Major
      Found in modules/auxiliary/admin/http/telpho10_credential_dump.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return nil
        Severity: Major
        Found in modules/auxiliary/admin/http/telpho10_credential_dump.rb - About 30 mins to fix

          Method untar has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def untar(tarfile)
    destination = tarfile.split('.tar').first
    FileUtils.mkdir_p(destination)
    File.open(tarfile, 'rb') do |file|
      Rex::Tar::Reader.new(file) do |tar|
          Severity: Minor
          Found in modules/auxiliary/admin/http/telpho10_credential_dump.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status