Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/http/typo3_news_module_sqli.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'TYPO3 News Module SQL Injection',
Severity: Minor
Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 1 hr to fix

    Method try_autodetect_patterns has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def try_autodetect_patterns
    print_status('Trying to automatically determine Pattern1 and Pattern2...')
    begin
      res = send_request_cgi({
        'method' => 'POST',
    Severity: Minor
    Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method try_autodetect_patterns has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def try_autodetect_patterns
    print_status('Trying to automatically determine Pattern1 and Pattern2...')
    begin
      res = send_request_cgi({
        'method' => 'POST',
    Severity: Minor
    Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 1 hr to fix

      Method blind has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def blind(field, table, condition, charset, digit_charset, patterns = {})
      Severity: Minor
      Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 45 mins to fix

        Method blind_size has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def blind_size(field, table, condition, size, charset, patterns = {})
        Severity: Minor
        Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 45 mins to fix

          Method select_position has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def select_position(field, table, condition, position, char)
          Severity: Minor
          Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 35 mins to fix

            Method blind_size has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def blind_size(field, table, condition, size, charset, patterns = {})
    str = ''
    for position in 0..size
      for char in charset.split('')
        payload = select_position(field, table, condition, position + 1, char)
            Severity: Minor
            Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                register_options(
      [
        OptString.new('TARGETURI', [true, 'The path of TYPO3', '/']),
        OptString.new('ID', [true, 'The id of TYPO3 news page', '1']),
        OptString.new('PATTERN1', [false, 'Pattern of the first article title', 'Article #1']),
            Severity: Minor
            Found in modules/auxiliary/admin/http/typo3_news_module_sqli.rb and 1 other location - About 25 mins to fix
            modules/auxiliary/scanner/http/bmc_trackit_passwd_reset.rb on lines 35..41

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 30.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status