Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method run has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    if user == pass
      print_error('Please select a password different than the username')
      return
    end
Severity: Minor
Found in modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb - About 1 hr to fix

    Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'vBulletin Administrator Account Creation',
    Severity: Minor
    Found in modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb - About 1 hr to fix

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

          register_options(
      [
        OptString.new('TARGETURI', [ true, 'The vbulletin URI', '/']),
        OptString.new('USERNAME', [true, 'The username for the new admin account', 'msf']),
        OptString.new('PASSWORD', [true, 'The password for the new admin account', 'password']),
      Severity: Major
      Found in modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb and 16 other locations - About 25 mins to fix
      modules/auxiliary/admin/http/joomla_registration_privesc.rb on lines 35..41
      modules/auxiliary/admin/http/kaseya_master_admin.rb on lines 36..42
      modules/auxiliary/gather/mantisbt_admin_sqli.rb on lines 33..39
      modules/auxiliary/scanner/http/riverbed_steelhead_vcx_file_read.rb on lines 31..37
      modules/auxiliary/scanner/sap/sap_soap_rfc_pfl_check_os_file_existence.rb on lines 51..56
      modules/auxiliary/scanner/sap/sap_soap_rfc_rzl_read_dir.rb on lines 51..56
      modules/auxiliary/scanner/telephony/wardial.rb on lines 48..54
      modules/exploits/linux/http/froxlor_log_path_rce.rb on lines 67..73
      modules/exploits/linux/http/seagate_nas_php_exec_noauth.rb on lines 48..53
      modules/exploits/unix/webapp/wp_google_document_embedder_exec.rb on lines 53..59
      modules/exploits/windows/http/ajaxpro_deserialization_rce.rb on lines 91..96
      modules/exploits/windows/http/apache_activemq_traversal_upload.rb on lines 61..66
      modules/exploits/windows/http/manageengine_adaudit_plus_authenticated_rce.rb on lines 89..94
      modules/exploits/windows/http/sharepoint_data_deserialization.rb on lines 77..82
      modules/exploits/windows/http/zentao_pro_rce.rb on lines 74..79
      modules/post/osx/manage/mount_share.rb on lines 51..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

            update_info(
        info,
        'Name' => 'vBulletin Administrator Account Creation',
        'Description' => %q{
          This module abuses the "install/upgrade.php" component on vBulletin 4.1+ and 4.5+ to
      Severity: Major
      Found in modules/auxiliary/admin/http/vbulletin_upgrade_admin.rb and 4 other locations - About 25 mins to fix
      modules/auxiliary/admin/scada/ge_proficy_substitute_traversal.rb on lines 13..33
      modules/auxiliary/admin/vnc/realvnc_41_bypass.rb on lines 10..33
      modules/auxiliary/dos/windows/http/ms10_065_ii6_asp_dos.rb on lines 11..32
      modules/auxiliary/spoof/dns/bailiwicked_host.rb on lines 13..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status