Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/http/webnms_cred_disclosure.rb

Summary

Maintainability
D
3 days
Test Coverage

Method super_redacted_deobfuscation has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
Open

  def super_redacted_deobfuscation(ciphertext)
    input = ciphertext
    input = input.gsub('Z', '000')

    base = '0'.upto('9').to_a + 'a'.upto('z').to_a + 'A'.upto('G').to_a
Severity: Minor
Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method super_redacted_deobfuscation has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def super_redacted_deobfuscation(ciphertext)
    input = ciphertext
    input = input.gsub('Z', '000')

    base = '0'.upto('9').to_a + 'a'.upto('z').to_a + 'A'.upto('G').to_a
Severity: Major
Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 4 hrs to fix

    Method run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    # version check will not stop the module, but it will try to
    # determine the version and print it if verbose is set to true
    version_check
    begin
    Severity: Major
    Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 2 hrs to fix

      Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    # version check will not stop the module, but it will try to
    # determine the version and print it if verbose is set to true
    version_check
    begin
      Severity: Minor
      Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'WebNMS Framework Server Credential Disclosure',
      Severity: Minor
      Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    if pos == 0
              if !startnum
                answer += '0'
              end
            else
        Severity: Major
        Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if ending[i] == base[pos]
              isthere = true
              partnum += pos.to_s
              if pos == 0
                if !startnum
          Severity: Major
          Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    isthere = false
        pos = 0
        until isthere
          if part[i] == base[pos]
            isthere = true
            Severity: Minor
            Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb and 1 other location - About 45 mins to fix
            modules/auxiliary/admin/http/webnms_cred_disclosure.rb on lines 201..216

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      isthere = false
          pos = 0
          until isthere
            if ending[i] == base[pos]
              isthere = true
            Severity: Minor
            Found in modules/auxiliary/admin/http/webnms_cred_disclosure.rb and 1 other location - About 45 mins to fix
            modules/auxiliary/admin/http/webnms_cred_disclosure.rb on lines 154..169

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status