Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/kerberos/keytab.rb

Summary

Maintainability
C
1 day
Test Coverage

Method add_keytab_entry has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def add_keytab_entry
    keytab_path = datastore['KEYTAB_FILE']
    keytab = read_or_initialize_keytab(keytab_path)

    principal = datastore['PRINCIPAL']
Severity: Major
Found in modules/auxiliary/admin/kerberos/keytab.rb - About 2 hrs to fix

    Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Kerberos keytab utilities',
    Severity: Minor
    Found in modules/auxiliary/admin/kerberos/keytab.rb - About 2 hrs to fix

      Method export_keytab_entries has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def export_keytab_entries
    unless framework.db.active
      print_error('export not available, because the database is not active.')
      return
    end
      Severity: Minor
      Found in modules/auxiliary/admin/kerberos/keytab.rb - About 1 hr to fix

        Method add_keytab_entry has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def add_keytab_entry
    keytab_path = datastore['KEYTAB_FILE']
    keytab = read_or_initialize_keytab(keytab_path)

    principal = datastore['PRINCIPAL']
        Severity: Minor
        Found in modules/auxiliary/admin/kerberos/keytab.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method list_keytab_entries has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def list_keytab_entries
    if datastore['KEYTAB_FILE'].blank? || !File.exist?(datastore['KEYTAB_FILE'])
      fail_with(Failure::BadConfig, 'Invalid key tab file')
    end
        Severity: Minor
        Found in modules/auxiliary/admin/kerberos/keytab.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status