Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'VMware vCenter Server vmdir Authentication Bypass',
Severity: Minor
Found in modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    unless new_username && new_password
      print_error('Please set the NEW_USERNAME and NEW_PASSWORD options to proceed')
      return
    end
    Severity: Minor
    Found in modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_admin has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def add_admin(ldap)
    user_info = {
      'objectClass' => %w[top person organizationalPerson user],
      'cn' => new_username,
      'sn' => 'vsphere.local',
    Severity: Minor
    Found in modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.rb - About 1 hr to fix

      Method add_admin has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def add_admin(ldap)
    user_info = {
      'objectClass' => %w[top person organizationalPerson user],
      'cn' => new_username,
      'sn' => 'vsphere.local',
      Severity: Minor
      Found in modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status