rapid7/metasploit-framework

View on GitHub
modules/auxiliary/admin/mssql/mssql_enum.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method run has 710 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    print_status("Running MS SQL Server Enumeration...")

    if !mssql_login_datastore
      print_error("Login was unsuccessful. Check your credentials.")
Severity: Major
Found in modules/auxiliary/admin/mssql/mssql_enum.rb - About 3 days to fix

    Method run has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        print_status("Running MS SQL Server Enumeration...")
    
        if !mssql_login_datastore
          print_error("Login was unsuccessful. Check your credentials.")
    Severity: Minor
    Found in modules/auxiliary/admin/mssql/mssql_enum.rb - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File mssql_enum.rb has 729 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Exploit::Remote::MSSQL
      include Msf::Auxiliary::Report
    
      def initialize(info = {})
    Severity: Major
    Found in modules/auxiliary/admin/mssql/mssql_enum.rb - About 1 day to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if vernum.join != "2000"
            if sysconfig['Database Mail XPs'] == 1
              print_status("\tDatabase Mail XPs is Enabled")
              report_note(:host => datastore['RHOST'],
                :proto => 'TCP',
      Severity: Major
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 2 other locations - About 2 hrs to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 90..121
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 200..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if vernum.join != "2000"
            if sysconfig['xp_cmdshell'] == 1
              print_status("\txp_cmdshell is Enabled")
              report_note(:host => datastore['RHOST'],
                :proto => 'TCP',
      Severity: Major
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 2 other locations - About 2 hrs to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 163..194
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 200..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if vernum.join != "2000"
            if sysconfig['Ole Automation Procedures'] == 1
              print_status("\tOle Automation Procedures are Enabled")
              report_note(:host => datastore['RHOST'],
                :proto => 'TCP',
      Severity: Major
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 2 other locations - About 2 hrs to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 90..121
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 163..194

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if vernum.join != "2000"
            print_status("Disabled Accounts:")
            disabledsyslogins = mssql_query("select name from master.sys.server_principals where is_disabled = 1")[:rows]
            if disabledsyslogins != nil
              disabledsyslogins.each do |acc|
      Severity: Major
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 2 other locations - About 1 hr to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 323..341
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 347..365

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if vernum.join != "2000"
            print_status("Password Expiration is not checked for:")
            passexsyslogins = mssql_query("select name from master.sys.sql_logins where is_expiration_checked = 0")[:rows]
            if passexsyslogins != nil
              passexsyslogins.each do |acc|
      Severity: Major
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 2 other locations - About 1 hr to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 299..317
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 323..341

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          if vernum.join != "2000"
            print_status("No Accounts Policy is set for:")
            nopolicysyslogins = mssql_query("select name from master.sys.sql_logins where is_policy_checked = 0")[:rows]
            if nopolicysyslogins != nil
              nopolicysyslogins.each do |acc|
      Severity: Major
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 2 other locations - About 1 hr to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 299..317
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 347..365

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  db_ind_files.each do |fn|
                    print_status("\t\t#{fn.join}")
                    report_note(:host => datastore['RHOST'],
                      :proto => 'TCP',
                      :port => datastore['RPORT'],
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 1 other location - About 30 mins to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 461..467

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            sameasuser.each do |up|
              print_status("\t#{up.join}")
              report_note(:host => datastore['RHOST'],
                :proto => 'TCP',
                :port => datastore['RPORT'],
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_enum.rb and 1 other location - About 30 mins to fix
      modules/auxiliary/admin/mssql/mssql_enum.rb on lines 246..252

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status