rapid7/metasploit-framework

View on GitHub
modules/auxiliary/admin/oracle/oraenum.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method run has 602 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    return if not check_dependencies

    begin
      # Get all values from v$parameter
Severity: Major
Found in modules/auxiliary/admin/oracle/oraenum.rb - About 3 days to fix

    Method run has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        return if not check_dependencies
    
        begin
          # Get all values from v$parameter
    Severity: Minor
    Found in modules/auxiliary/admin/oracle/oraenum.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File oraenum.rb has 621 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Auxiliary::Report
      include Msf::Exploit::ORACLE
    
      def initialize(info = {})
    Severity: Major
    Found in modules/auxiliary/admin/oracle/oraenum.rb - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          begin
      
            if majorrel.join.to_i < 11
      
              query = %Q|
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 1 other location - About 2 hrs to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 461..510

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          begin
            if majorrel.join.to_i < 11
              query = %Q|
                SELECT username, password
                FROM dba_users
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 1 other location - About 2 hrs to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 408..459

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT grantee
              FROM dba_role_privs
              WHERE granted_role = 'DBA'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 541..567
      modules/auxiliary/admin/oracle/oraenum.rb on lines 569..596
      modules/auxiliary/admin/oracle/oraenum.rb on lines 598..626

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              select grantee
              from dba_sys_privs
              where privilege = 'CREATE LIBRARY'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 512..539
      modules/auxiliary/admin/oracle/oraenum.rb on lines 541..567
      modules/auxiliary/admin/oracle/oraenum.rb on lines 569..596

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT grantee
              FROM dba_sys_privs
              WHERE privilege = 'ALTER SYSTEM'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 512..539
      modules/auxiliary/admin/oracle/oraenum.rb on lines 569..596
      modules/auxiliary/admin/oracle/oraenum.rb on lines 598..626

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT grantee
              FROM dba_sys_privs
              WHERE privilege = 'JAVA ADMIN'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 512..539
      modules/auxiliary/admin/oracle/oraenum.rb on lines 541..567
      modules/auxiliary/admin/oracle/oraenum.rb on lines 598..626

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT limit
              FROM dba_profiles
              WHERE resource_name = 'PASSWORD_REUSE_TIME'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 4 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 203..228
      modules/auxiliary/admin/oracle/oraenum.rb on lines 230..255
      modules/auxiliary/admin/oracle/oraenum.rb on lines 257..282
      modules/auxiliary/admin/oracle/oraenum.rb on lines 284..309

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if vparm["audit_sys_operations"] == "FALSE"
              print_status("\tAuditing of SYS Operations is not enabled!")
              report_note(
                :host => datastore['RHOST'],
                :proto => 'tcp',
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 71..92
      modules/auxiliary/admin/oracle/oraenum.rb on lines 126..147
      modules/auxiliary/admin/oracle/oraenum.rb on lines 153..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if vparm["audit_trail"] == "NONE"
              print_status("\tDatabase Auditing is not enabled!")
              report_note(
                :host => datastore['RHOST'],
                :proto => 'tcp',
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 95..116
      modules/auxiliary/admin/oracle/oraenum.rb on lines 126..147
      modules/auxiliary/admin/oracle/oraenum.rb on lines 153..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT limit
              FROM dba_profiles
              WHERE resource_name = 'FAILED_LOGIN_ATTEMPTS'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 4 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 203..228
      modules/auxiliary/admin/oracle/oraenum.rb on lines 257..282
      modules/auxiliary/admin/oracle/oraenum.rb on lines 284..309
      modules/auxiliary/admin/oracle/oraenum.rb on lines 311..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT limit
              FROM dba_profiles
              WHERE resource_name = 'PASSWORD_LIFE_TIME'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 4 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 203..228
      modules/auxiliary/admin/oracle/oraenum.rb on lines 230..255
      modules/auxiliary/admin/oracle/oraenum.rb on lines 257..282
      modules/auxiliary/admin/oracle/oraenum.rb on lines 311..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT limit
              FROM dba_profiles
              WHERE resource_name = 'PASSWORD_GRACE_TIME'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 4 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 203..228
      modules/auxiliary/admin/oracle/oraenum.rb on lines 230..255
      modules/auxiliary/admin/oracle/oraenum.rb on lines 284..309
      modules/auxiliary/admin/oracle/oraenum.rb on lines 311..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              if vparm["dblink_encrypt_login"] == "FALSE"
                print_status("\tLink Encryption for Logins is not Enabled")
                report_note(
                  :host => datastore['RHOST'],
                  :proto => 'tcp',
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 71..92
      modules/auxiliary/admin/oracle/oraenum.rb on lines 95..116
      modules/auxiliary/admin/oracle/oraenum.rb on lines 126..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if vparm["sql92_security"] == "FALSE"
              print_status("\tSQL92 Security restriction on SELECT is not Enabled")
              report_note(
                :host => datastore['RHOST'],
                :proto => 'tcp',
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 3 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 71..92
      modules/auxiliary/admin/oracle/oraenum.rb on lines 95..116
      modules/auxiliary/admin/oracle/oraenum.rb on lines 153..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          begin
            query = %Q|
              SELECT limit
              FROM dba_profiles
              WHERE resource_name = 'PASSWORD_LOCK_TIME'
      Severity: Major
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 4 other locations - About 1 hr to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 230..255
      modules/auxiliary/admin/oracle/oraenum.rb on lines 257..282
      modules/auxiliary/admin/oracle/oraenum.rb on lines 284..309
      modules/auxiliary/admin/oracle/oraenum.rb on lines 311..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            report_note(
              :host => datastore['RHOST'],
              :proto => 'tcp',
              :sname => 'oracle',
              :port => datastore['RPORT'],
      Severity: Minor
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 1 other location - About 20 mins to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 179..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            report_note(
              :host => datastore['RHOST'],
              :proto => 'tcp',
              :sname => 'oracle',
              :port => datastore['RPORT'],
      Severity: Minor
      Found in modules/auxiliary/admin/oracle/oraenum.rb and 1 other location - About 20 mins to fix
      modules/auxiliary/admin/oracle/oraenum.rb on lines 189..198

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status