Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb

Summary

Maintainability
D
2 days
Test Coverage

File sap_igs_xmlchart_xxe.rb has 338 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Auxiliary

  include Msf::Exploit::Remote::HttpClient

  def initialize(info = {})
Severity: Minor
Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 4 hrs to fix

    Method check has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    # Set up variables
    os_release = ''
    os_release_file = '/etc/os-release'
    Severity: Minor
    Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    # Set up variables
    os_release = ''
    os_release_file = '/etc/os-release'
    Severity: Major
    Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 2 hrs to fix

      Method action_file_read has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def action_file_read
    # Set up XML data for HTTP request
    setup_xml_and_variables
    make_post_data(@file, dos: false)
      Severity: Minor
      Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'SAP Internet Graphics Server (IGS) XMLCHART XXE',
      Severity: Minor
      Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 1 hr to fix

        Method action_file_read has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def action_file_read
    # Set up XML data for HTTP request
    setup_xml_and_variables
    make_post_data(@file, dos: false)
        Severity: Minor
        Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 1 hr to fix

          Method action_dos has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def action_dos
    # Set up XML data for HTTP request
    setup_xml_and_variables
    make_post_data(@file, dos: true)
          Severity: Minor
          Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 1 hr to fix

            Method setup_xml_and_variables has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def setup_xml_and_variables
    @host = datastore['RHOSTS']
    @port = datastore['RPORT']
    @path = datastore['URIPATH']
    @file = datastore['FILE']
            Severity: Minor
            Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 1 hr to fix

              Method make_post_data has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def make_post_data(file_name, dos: false)
    if !dos
      make_xxe_xml(file_name)
    else
      @xxe_xml[:data] = %(<?xml version='1.0' encoding='UTF-8'?>
              Severity: Minor
              Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 1 hr to fix

                Method analyze_first_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def analyze_first_response(html_response)
    get_download_link(html_response)
    if !@download_link.to_s.empty?

      # Send second HTTP request
                Severity: Minor
                Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method send_first_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def send_first_request
    # Send first HTTP request
    begin
      first_response = nil
      first_response = send_request_cgi(
                Severity: Minor
                Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    rescue StandardError => e
      print_error("Failed to retrieve SAP IGS page at #{@schema}#{@host}:#{@port}#{@path}")
      vprint_error("Error #{e.class}: #{e}")
      return -1
    end
                Severity: Minor
                Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb and 1 other location - About 15 mins to fix
                modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb on lines 204..208

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      rescue StandardError => e
        print_error("Failed to retrieve SAP IGS page: #{@schema}#{@host}:#{@port}#{@download_link}")
        vprint_error("Error #{e.class}: #{e}")
        return -1 # Some exception was thrown whilst making the second HTTP request!
      end
                Severity: Minor
                Found in modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb and 1 other location - About 15 mins to fix
                modules/auxiliary/admin/sap/sap_igs_xmlchart_xxe.rb on lines 173..177

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status