Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/admin/scada/yokogawa_bkbcopyd_client.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method exploit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    @srvport = rand(1024..65535)
    print_status("#{@srvport}")
    # We make the client connection before giving control to the TCP Server
    # in order to release the src port, so the server can start correctly
Severity: Minor
Found in modules/auxiliary/admin/scada/yokogawa_bkbcopyd_client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    @srvport = rand(1024..65535)
    print_status("#{@srvport}")
    # We make the client connection before giving control to the TCP Server
    # in order to release the src port, so the server can start correctly
Severity: Minor
Found in modules/auxiliary/admin/scada/yokogawa_bkbcopyd_client.rb - About 1 hr to fix

    Method initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Yokogawa BKBCopyD.exe Client',
      'Description'    => %q{
        This module allows an unauthenticated user to interact with the Yokogawa
    Severity: Minor
    Found in modules/auxiliary/admin/scada/yokogawa_bkbcopyd_client.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status