Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/analyze/crack_windows.rb

Summary

Maintainability
F
3 days
Test Coverage

Method run has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    # we have to overload the process_cracker_results from password_cracker.rb since LANMAN
    # is a special case where we may need to do some combining
    def process_cracker_results(results, cred)
      return results if cred['core_id'].nil? # make sure we have good data
Severity: Minor
Found in modules/auxiliary/analyze/crack_windows.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_results has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    def check_results(passwords, results, hash_type, method)
      passwords.each do |password_line|
        password_line.chomp!
        next if password_line.blank?
Severity: Minor
Found in modules/auxiliary/analyze/crack_windows.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 170 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    # we have to overload the process_cracker_results from password_cracker.rb since LANMAN
    # is a special case where we may need to do some combining
    def process_cracker_results(results, cred)
      return results if cred['core_id'].nil? # make sure we have good data
Severity: Major
Found in modules/auxiliary/analyze/crack_windows.rb - About 6 hrs to fix

    Method initialize has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name' => 'Password Cracker: Windows',
      'Description' => %(
          This module uses John the Ripper or Hashcat to identify weak passwords that have been
    Severity: Minor
    Found in modules/auxiliary/analyze/crack_windows.rb - About 1 hr to fix

      Method process_cracker_results has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def process_cracker_results(results, cred)
      return results if cred['core_id'].nil? # make sure we have good data

      # make sure we dont add the same one again
      if results.select { |r| r.first == cred['core_id'] }.empty?
      Severity: Minor
      Found in modules/auxiliary/analyze/crack_windows.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if results.select { |r| r.first == cred['core_id'] }.empty?
        results << [cred['core_id'], cred['hash_type'], cred['username'], cred['password'], cred['method']]
      Severity: Minor
      Found in modules/auxiliary/analyze/crack_windows.rb and 1 other location - About 25 mins to fix
      lib/msf/core/auxiliary/password_cracker.rb on lines 194..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 7 locations. Consider refactoring.
      Open

        def show_command(cracker_instance)
    return unless datastore['ShowCommand']

    if action.name == 'john'
      cmd = cracker_instance.john_crack_command
      Severity: Major
      Found in modules/auxiliary/analyze/crack_windows.rb and 6 other locations - About 25 mins to fix
      modules/auxiliary/analyze/crack_aix.rb on lines 40..48
      modules/auxiliary/analyze/crack_databases.rb on lines 53..61
      modules/auxiliary/analyze/crack_linux.rb on lines 53..61
      modules/auxiliary/analyze/crack_mobile.rb on lines 40..48
      modules/auxiliary/analyze/crack_osx.rb on lines 42..50
      modules/auxiliary/analyze/crack_webapps.rb on lines 43..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            'Name' => 'Password Cracker: Windows',
      'Description' => %(
          This module uses John the Ripper or Hashcat to identify weak passwords that have been
        acquired from Windows systems.
        LANMAN is format 3000 in hashcat.
      Severity: Minor
      Found in modules/auxiliary/analyze/crack_windows.rb and 3 other locations - About 20 mins to fix
      modules/auxiliary/analyze/crack_aix.rb on lines 13..30
      modules/auxiliary/analyze/crack_databases.rb on lines 16..39
      modules/auxiliary/analyze/crack_linux.rb on lines 13..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status