Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/cloud/aws/enum_s3.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    region = datastore['REGION']

    @s3 = Aws::S3::Client.new(
      region: "us-west-2",      # This doesn't actually filter anything, but
Severity: Minor
Found in modules/auxiliary/cloud/aws/enum_s3.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method describe_s3_bucket has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def describe_s3_bucket(i)
    print_good "  Name:           #{i.name}"
    print_good "  Creation Date:  #{i.creation_date}"
    print_good "  # of Objects:   #{@s3.list_objects_v2(bucket: i.name).contents.length}"
    print_good "  Region:         #{@s3.get_bucket_location(bucket: i.name).location_constraint}"
Severity: Minor
Found in modules/auxiliary/cloud/aws/enum_s3.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    region = datastore['REGION']

    @s3 = Aws::S3::Client.new(
      region: "us-west-2",      # This doesn't actually filter anything, but
Severity: Minor
Found in modules/auxiliary/cloud/aws/enum_s3.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status