Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/cloud/aws/enum_ssm.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method run has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    credentials = ::Aws::Credentials.new(datastore['ACCESS_KEY_ID'], datastore['SECRET_ACCESS_KEY'])
    vprint_status "Checking #{datastore['REGION']}..."
    client = ::Aws::SSM::Client.new(
      region: datastore['REGION'],
Severity: Major
Found in modules/auxiliary/cloud/aws/enum_ssm.rb - About 2 hrs to fix

    Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Amazon Web Services EC2 SSM enumeration',
    Severity: Minor
    Found in modules/auxiliary/cloud/aws/enum_ssm.rb - About 1 hr to fix

      Method get_ssm_socket has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_ssm_socket(client, ec2_id)
    # Verify the connection params and availability of instance
    inv_params = {
      filters: [
        {
      Severity: Minor
      Found in modules/auxiliary/cloud/aws/enum_ssm.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    credentials = ::Aws::Credentials.new(datastore['ACCESS_KEY_ID'], datastore['SECRET_ACCESS_KEY'])
    vprint_status "Checking #{datastore['REGION']}..."
    client = ::Aws::SSM::Client.new(
      region: datastore['REGION'],
        Severity: Minor
        Found in modules/auxiliary/cloud/aws/enum_ssm.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status